PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Add the ability to have a specific required corrupted implicit added to the trade search for the Timeless Jewel finder
まだ誰も着手していません。
- 主要言語
- Lua
- スター
- 5.4k
- フォーク
- 2.4k
- 平均マージ
- 1日 12時間
- マージ済み PR(30日)
- 26
説明
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
As far as I can tell, currently the only way to search for timeless jewels that also have a specific corrupted implicit (for example: "corrupted blood cannot be inflicted on you") is to manually add it into every trade URL search via the "AND" stat group. For very common jewel seeds with hundreds or thousands of possible seeds it's especially bad.
I know this is a somewhat niche feature and only really useful for min-maxing, but I was trying to specifically find a glorious vanity socketed in the mind over matter socket with one specific node (lightning damage leeched as life) replacing the "arcanist's dominion" node while also having the immune to corrupted blood implicit. There's thousands of seeds with that specific node but very few that also have the corrupted blood implicit.
Describe the solution you'd like
It would be very nice to have an option in the Timeless Jewel finder to add in a required corrupted implicit that gets added into the trade search URL as well as the jewel seeds.
Even going through 20 no result searches would be much better than needing to manually add in the corrupted implicit to every search (and it having no results anyway).
Describe alternatives you've considered
As far as I know, the only way to currently achieve it is by manually adding the implicit into every jewel's trade search with the "AND" stat group.
I found a couple listings after going through like 20, but it took a long time adding it in manually every time, and finding the cheapest listing would take forever
Additional context
No response
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まず Timeless Jewel finder と、その trade 検索 URL を構築するコードを見つけます。jewel seed と既存の AND stat group がどのように選択されるかを追跡し、要求された required corrupted implicit を追加して、seed 検索と生成される trade URL の両方に含まれるようにします。完了条件は、そのオプションを選択でき、その implicit を含む検索が生成されることです。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- lua
- 領域
- search, tooling
- issue の種類
- 機能追加
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 静か
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 48/100