PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Add the ability to have a specific required corrupted implicit added to the trade search for the Timeless Jewel finder
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
As far as I can tell, currently the only way to search for timeless jewels that also have a specific corrupted implicit (for example: "corrupted blood cannot be inflicted on you") is to manually add it into every trade URL search via the "AND" stat group. For very common jewel seeds with hundreds or thousands of possible seeds it's especially bad.
I know this is a somewhat niche feature and only really useful for min-maxing, but I was trying to specifically find a glorious vanity socketed in the mind over matter socket with one specific node (lightning damage leeched as life) replacing the "arcanist's dominion" node while also having the immune to corrupted blood implicit. There's thousands of seeds with that specific node but very few that also have the corrupted blood implicit.
Describe the solution you'd like
It would be very nice to have an option in the Timeless Jewel finder to add in a required corrupted implicit that gets added into the trade search URL as well as the jewel seeds.
Even going through 20 no result searches would be much better than needing to manually add in the corrupted implicit to every search (and it having no results anyway).
Describe alternatives you've considered
As far as I know, the only way to currently achieve it is by manually adding the implicit into every jewel's trade search with the "AND" stat group.
I found a couple listings after going through like 20, but it took a long time adding it in manually every time, and finding the cheapest listing would take forever
Additional context
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, den Timeless Jewel finder und den Code zu finden, der seine Trade-Such-URLs erstellt. Verfolge, wie Jewel-Seeds und vorhandene AND-Stat-Gruppen ausgewählt werden, und füge dann das angeforderte erforderliche korrumpierte Implicit hinzu, sodass es sowohl in der Seed-Suche als auch in den generierten Trade-URLs enthalten ist. Erledigt ist die Aufgabe, wenn die Option ausgewählt werden kann und Suchanfragen erzeugt, die dieses Implicit enthalten.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- search, tooling
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 48/100