PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add the ability to have a specific required corrupted implicit added to the trade search for the Timeless Jewel finder

Ouverte
#9,804 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

enhancement
Langage dominant
Lua
Étoiles
5.4k
Forks
2.4k
Merge moyen
1 j 12 h
PR mergées (30 j)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

As far as I can tell, currently the only way to search for timeless jewels that also have a specific corrupted implicit (for example: "corrupted blood cannot be inflicted on you") is to manually add it into every trade URL search via the "AND" stat group. For very common jewel seeds with hundreds or thousands of possible seeds it's especially bad.

I know this is a somewhat niche feature and only really useful for min-maxing, but I was trying to specifically find a glorious vanity socketed in the mind over matter socket with one specific node (lightning damage leeched as life) replacing the "arcanist's dominion" node while also having the immune to corrupted blood implicit. There's thousands of seeds with that specific node but very few that also have the corrupted blood implicit.

Describe the solution you'd like

It would be very nice to have an option in the Timeless Jewel finder to add in a required corrupted implicit that gets added into the trade search URL as well as the jewel seeds.

Even going through 20 no result searches would be much better than needing to manually add in the corrupted implicit to every search (and it having no results anyway).

Describe alternatives you've considered

As far as I know, the only way to currently achieve it is by manually adding the implicit into every jewel's trade search with the "AND" stat group.

I found a couple listings after going through like 20, but it took a long time adding it in manually every time, and finding the cheapest listing would take forever

Additional context

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par localiser le Timeless Jewel finder et le code qui construit ses URLs de recherche de trade. Suivez la façon dont les jewel seeds et les groupes de stats AND existants sont sélectionnés, puis ajoutez le corrupted implicit requis afin qu’il soit inclus à la fois dans la recherche de seeds et dans les URLs de trade générées. C’est terminé lorsque l’option peut être sélectionnée et qu’elle produit des recherches contenant cet implicit.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
lua
Domaine
search, tooling
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.