PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add the ability to have a specific required corrupted implicit added to the trade search for the Timeless Jewel finder

Aperta
#9,804 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

enhancement
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

As far as I can tell, currently the only way to search for timeless jewels that also have a specific corrupted implicit (for example: "corrupted blood cannot be inflicted on you") is to manually add it into every trade URL search via the "AND" stat group. For very common jewel seeds with hundreds or thousands of possible seeds it's especially bad.

I know this is a somewhat niche feature and only really useful for min-maxing, but I was trying to specifically find a glorious vanity socketed in the mind over matter socket with one specific node (lightning damage leeched as life) replacing the "arcanist's dominion" node while also having the immune to corrupted blood implicit. There's thousands of seeds with that specific node but very few that also have the corrupted blood implicit.

Describe the solution you'd like

It would be very nice to have an option in the Timeless Jewel finder to add in a required corrupted implicit that gets added into the trade search URL as well as the jewel seeds.

Even going through 20 no result searches would be much better than needing to manually add in the corrupted implicit to every search (and it having no results anyway).

Describe alternatives you've considered

As far as I know, the only way to currently achieve it is by manually adding the implicit into every jewel's trade search with the "AND" stat group.

I found a couple listings after going through like 20, but it took a long time adding it in manually every time, and finding the cheapest listing would take forever

Additional context

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia individuando il Timeless Jewel finder e il codice che costruisce i relativi URL di ricerca del trade. Traccia come vengono selezionati i jewel seeds e i gruppi di stat AND esistenti, quindi aggiungi il corrupted implicit richiesto in modo che venga incluso sia nella ricerca dei seed sia negli URL di trade generati. Il lavoro è completato quando l’opzione può essere selezionata e produce ricerche contenenti quell’implicit.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
search, tooling
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.