PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Sacrifice support on totems uses player life instead of totem life
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
Not visible, but clearly scaling off totem life.
What is the value from the calculation in Path of Building?
Scales off player life (spell totem + sacrifice + fireball shows damage varying as player level is adjusted).
How to reproduce the issue
Set up a skill link of spell link of spell totem + sacrifice + fireball. Note that changing spell totem level has no effect on damage (even though it affects totem life and thus should), but changing player level does (even though it does not affect totem life and thus shouldn't).
Character build code
Don't have one handy.
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported spell totem + sacrifice + fireball setup and compare damage while changing spell totem level versus player level. Trace the totem-life and sacrifice calculation paths in the Lua code; done means damage scales with totem life rather than player life and the regression is covered by the relevant tests, if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100