PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Damage conversions for new weapon passives(i.e. Exsanguinate into fire and removing the chaos conversion for cobra lash)

Abierto
#6,060 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

I am currently playing a full fire convert exsanguinate elementalist as well as a bleed full phys cobra lash gladiator. The weapon passives in PoB are in red text so I'm assuming that it's a feature that is either currently being worked on and is non-functional or is not currently being worked on. These missing functionalities make it very hard to correctly plan out and make build choices.

weaponconv1
weaponconv2

Describe the solution you'd like

I would just like these and other damage conversion passives from the new weapon passives to function in PoB.

Describe alternatives you've considered

I've tried to put in custom modifiers on these items to make them do in PoB what they do in game but I failed to do it properly, if it's even possible to change the skill interactions with item modifiers.

Additional context

Both damage portions of exsanguinate remain physical in PoB, and it isn't updated by all relevant talents.

weaponconv3
weaponconv4

Cobra Lash doesn't un-convert the chaos damage so it throws off all of the bleed calculations/weighting

weaponconv5

Thanks for your time, and thanks for all of your efforts with PoB. I really enjoy the application.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

No se nombran archivos, pruebas ni puntos de entrada. Empieza localizando el manejo de las pasivas de arma y la conversión de daño para Exsanguinate y Cobra Lash, y después verifica cómo afectan las conversiones solicitadas tanto a las partes del daño como a los cálculos de sangrado; se considera completado cuando las pasivas relevantes se reflejan correctamente en PoB.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.