PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Damage conversions for new weapon passives(i.e. Exsanguinate into fire and removing the chaos conversion for cobra lash)
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
I am currently playing a full fire convert exsanguinate elementalist as well as a bleed full phys cobra lash gladiator. The weapon passives in PoB are in red text so I'm assuming that it's a feature that is either currently being worked on and is non-functional or is not currently being worked on. These missing functionalities make it very hard to correctly plan out and make build choices.
Describe the solution you'd like
I would just like these and other damage conversion passives from the new weapon passives to function in PoB.
Describe alternatives you've considered
I've tried to put in custom modifiers on these items to make them do in PoB what they do in game but I failed to do it properly, if it's even possible to change the skill interactions with item modifiers.
Additional context
Both damage portions of exsanguinate remain physical in PoB, and it isn't updated by all relevant talents.
Cobra Lash doesn't un-convert the chaos damage so it throws off all of the bleed calculations/weighting
Thanks for your time, and thanks for all of your efforts with PoB. I really enjoy the application.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the weapon-passive and damage-conversion handling for Exsanguinate and Cobra Lash, then verify how the requested conversions affect both damage portions and bleed calculations; done means the relevant passives are reflected correctly in PoB.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100