Sorting uniques yields incorrectly sorted items when main skill is minion based

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

I understand the sorting might be tricky because some sorting options need to apply to minions, such as DPS or life when a minion skill is selected.

Except some sorting options seem to player-only (strength, dexterity, intelligence, effective hit pool, and so on). So for these, I would expect to have items being sorted based on the character itself rather than the skill selected.

What is the actual behaviour/value?

When sorting unique items, many of the sorting options yields the wrong results.
I identified two cases where sorting results are either alphabetically sorted (case 1) or seemingly random (case 2)

The root cause of the issue seems to be linked with having a Main Skill configured on a minion skill (in my case Absolution).
Selecting a non-minion skill causes the sorting option to yield an adequately sorted list.

Case 1 - Sorting options yielding alphabetically sorted list

Examples (with 1st result highlighted)

• Sort by Mana:
  

• Sort by Strength:
  

• Sort by Dexterity:
  

Case 2 - Sorting options yielding list in seemingly random order

• Sort by Effective Hit Pool:

  • 1st item:
  • 2nd item:
  • 10th item:

How to reproduce the issue

1. Add any minion skill as main skill, for example: Absolution
2. Sort unique items by metrics only affecting the player, for example: Strength, Dexterity, Intelligence or Effective Health Pool
3. Then switch the main skill to a non-minion skill => results are different from step 2.

Character build code

https://pobb.in/2pE4Szyp5TuB

Screenshots

No response

Issue không xác định tệp mã nguồn hoặc bài kiểm thử nào. Hãy tải character build được liên kết, chọn một kỹ năng minion như Absolution và tái hiện việc sắp xếp các vật phẩm unique theo Strength, Dexterity, Mana hoặc Effective Hit Pool, sau đó so sánh với một kỹ năng chính không phải minion. Được xem là hoàn tất khi các chỉ số chỉ dành cho người chơi được sắp xếp nhất quán bất kể kỹ năng được chọn, với độ bao phủ hồi quy cho các trường hợp đã báo cáo.