PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Sorting uniques yields incorrectly sorted items when main skill is minion based

Abierto
#5,002 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

image

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

I understand the sorting might be tricky because some sorting options need to apply to minions, such as DPS or life when a minion skill is selected.

Except some sorting options seem to player-only (strength, dexterity, intelligence, effective hit pool, and so on). So for these, I would expect to have items being sorted based on the character itself rather than the skill selected.

What is the actual behaviour/value?

When sorting unique items, many of the sorting options yields the wrong results.
I identified two cases where sorting results are either alphabetically sorted (case 1) or seemingly random (case 2)

The root cause of the issue seems to be linked with having a Main Skill configured on a minion skill (in my case Absolution).
Selecting a non-minion skill causes the sorting option to yield an adequately sorted list.

Case 1 - Sorting options yielding alphabetically sorted list

Examples (with 1st result highlighted)

  • Sort by Mana:
    image

  • Sort by Strength:
    image

  • Sort by Dexterity:
    image

Case 2 - Sorting options yielding list in seemingly random order

  • Sort by Effective Hit Pool:

    • 1st item: image
    • 2nd item: image
    • 10th item: image
How to reproduce the issue
  1. Add any minion skill as main skill, for example: Absolution
  2. Sort unique items by metrics only affecting the player, for example: Strength, Dexterity, Intelligence or Effective Health Pool
  3. Then switch the main skill to a non-minion skill => results are different from step 2.
Character build code
https://pobb.in/2pE4Szyp5TuB
Screenshots

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

El issue no identifica ningún archivo fuente ni prueba. Carga la build de personaje enlazada, selecciona una habilidad de minion como Absolution y reproduce la ordenación de objetos únicos por Strength, Dexterity, Mana o Effective Hit Pool; después, compárala con una habilidad principal que no sea de minion. Se considera terminado cuando las métricas exclusivas del jugador se ordenan de forma coherente independientemente de la habilidad seleccionada, con cobertura de regresión para los casos reportados.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
desktop
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.