PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Sorting uniques yields incorrectly sorted items when main skill is minion based

未关闭
#5,002 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug
主要语言
Lua
星标
5.4k
派生
2.4k
平均合并
1 天 12 小时
30 天内合并 PR
26

描述

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

image

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

I understand the sorting might be tricky because some sorting options need to apply to minions, such as DPS or life when a minion skill is selected.

Except some sorting options seem to player-only (strength, dexterity, intelligence, effective hit pool, and so on). So for these, I would expect to have items being sorted based on the character itself rather than the skill selected.

What is the actual behaviour/value?

When sorting unique items, many of the sorting options yields the wrong results.
I identified two cases where sorting results are either alphabetically sorted (case 1) or seemingly random (case 2)

The root cause of the issue seems to be linked with having a Main Skill configured on a minion skill (in my case Absolution).
Selecting a non-minion skill causes the sorting option to yield an adequately sorted list.

Case 1 - Sorting options yielding alphabetically sorted list

Examples (with 1st result highlighted)

  • Sort by Mana:
    image

  • Sort by Strength:
    image

  • Sort by Dexterity:
    image

Case 2 - Sorting options yielding list in seemingly random order

  • Sort by Effective Hit Pool:

    • 1st item: image
    • 2nd item: image
    • 10th item: image
How to reproduce the issue
  1. Add any minion skill as main skill, for example: Absolution
  2. Sort unique items by metrics only affecting the player, for example: Strength, Dexterity, Intelligence or Effective Health Pool
  3. Then switch the main skill to a non-minion skill => results are different from step 2.
Character build code
https://pobb.in/2pE4Szyp5TuB
Screenshots

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

issue 中没有确定源文件或测试。加载链接的角色 build,选择 Absolution 之类的 minion 技能,复现按 Strength、Dexterity、Mana 或 Effective Hit Pool 对 unique 物品进行排序的情况,然后与非 minion 主技能进行比较。完成标准是:仅玩家指标无论选择哪种技能都能保持一致排序,并为报告的案例提供回归覆盖。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua
领域
desktop
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。