PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Minion Instability damage inaccuracies
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 5.4k
- Forks
- 2.4k
- Merge moyen
- 1 j 12 h
- PR mergées (30 j)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Minion Instability is an on death effect and should not be affected by things like attack/cast rate, or "hits with this weapon" (i.e. The Iron Mass).
What is the actual behaviour/value?
Minion Instability scales its Total DPS and Full DPS by cast speed (listed in PoB as Attack/Cast Rate). It also gets triple damage from The Iron Mass' "Summoned Skeleton Warriors deal Triple Damage with this Weapon if you've Hit with this Weapon Recently" when the conditional is met.
How to reproduce the issue
- Allocate Minion Instability
- Get a source of minion cast speed
- Setup Summon Skeletons as a link
- Select Minion Instability as the skill the skeletons are using
- Total DPS scales average damage by Cast Rate but it shows Total DPS inc. Bleed/Ignite/Poison as if it were 1.0 Cast Rate (these disappear when you go back to 1.0 Cast Rate)
- Add The Iron Mass as the main weapon
- Enable the When in Combat conditional "Have you Hit Recently With Your Weapon?"
- Observe triple damage is applied here.
For testing The Iron Mass in-game
- Allocate Minion Instability
- Have The Iron Mass in main hand, Earendel's Embrace in your off hand
- Setup a minion link with Summon Skeletons and Infernal Legion (low level preferred for both)
- Enter PvP with another player
- Summon skeletons and observe the damage they deal when attacking as well as exploding (these can be done separately).
- Default attack the opponent until you land a hit and repeat step 6.
- They should deal triple damage when default attacking, but do the same damage when exploding.
Character build code
https://pastebin.com/7eErJ0tL
Screenshots
No response
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par charger le code de build Path of Building fourni et suivre le calcul des dégâts de Minion Instability décrit dans les étapes de reproduction. Comparez son traitement de la vitesse d'incantation et de la condition de The Iron Mass avec le comportement attendu à la mort. Le travail est terminé lorsque les dégâts de l'explosion sont indépendants de la vitesse d'attaque/d'incantation et des dégâts conditionnels liés aux coups portés avec l'arme, tandis que les attaques ordinaires conservent ces effets.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua
- Domaine
- game-dev
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100