PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Minion Instability damage inaccuracies
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Minion Instability is an on death effect and should not be affected by things like attack/cast rate, or "hits with this weapon" (i.e. The Iron Mass).
What is the actual behaviour/value?
Minion Instability scales its Total DPS and Full DPS by cast speed (listed in PoB as Attack/Cast Rate). It also gets triple damage from The Iron Mass' "Summoned Skeleton Warriors deal Triple Damage with this Weapon if you've Hit with this Weapon Recently" when the conditional is met.
How to reproduce the issue
- Allocate Minion Instability
- Get a source of minion cast speed
- Setup Summon Skeletons as a link
- Select Minion Instability as the skill the skeletons are using
- Total DPS scales average damage by Cast Rate but it shows Total DPS inc. Bleed/Ignite/Poison as if it were 1.0 Cast Rate (these disappear when you go back to 1.0 Cast Rate)
- Add The Iron Mass as the main weapon
- Enable the When in Combat conditional "Have you Hit Recently With Your Weapon?"
- Observe triple damage is applied here.
For testing The Iron Mass in-game
- Allocate Minion Instability
- Have The Iron Mass in main hand, Earendel's Embrace in your off hand
- Setup a minion link with Summon Skeletons and Infernal Legion (low level preferred for both)
- Enter PvP with another player
- Summon skeletons and observe the damage they deal when attacking as well as exploding (these can be done separately).
- Default attack the opponent until you land a hit and repeat step 6.
- They should deal triple damage when default attacking, but do the same damage when exploding.
Character build code
https://pastebin.com/7eErJ0tL
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza cargando el código de build de Path of Building proporcionado y siguiendo el cálculo de daño de Minion Instability descrito en los pasos de reproducción. Compara el tratamiento de la velocidad de lanzamiento y la condición de The Iron Mass con el comportamiento esperado al morir. Se considera terminado cuando el daño de la explosión es independiente de la velocidad de ataque/lanzamiento y del daño condicional al golpear con el arma, mientras que los ataques normales conservan esos efectos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- game-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100