PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Minion Instability damage inaccuracies

Open
#4,864 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Minion Instability is an on death effect and should not be affected by things like attack/cast rate, or "hits with this weapon" (i.e. The Iron Mass).

What is the actual behaviour/value?

Minion Instability scales its Total DPS and Full DPS by cast speed (listed in PoB as Attack/Cast Rate). It also gets triple damage from The Iron Mass' "Summoned Skeleton Warriors deal Triple Damage with this Weapon if you've Hit with this Weapon Recently" when the conditional is met.

How to reproduce the issue
  1. Allocate Minion Instability
  2. Get a source of minion cast speed
  3. Setup Summon Skeletons as a link
  4. Select Minion Instability as the skill the skeletons are using
  5. Total DPS scales average damage by Cast Rate but it shows Total DPS inc. Bleed/Ignite/Poison as if it were 1.0 Cast Rate (these disappear when you go back to 1.0 Cast Rate)
  6. Add The Iron Mass as the main weapon
  7. Enable the When in Combat conditional "Have you Hit Recently With Your Weapon?"
  8. Observe triple damage is applied here.

For testing The Iron Mass in-game

  1. Allocate Minion Instability
  2. Have The Iron Mass in main hand, Earendel's Embrace in your off hand
  3. Setup a minion link with Summon Skeletons and Infernal Legion (low level preferred for both)
  4. Enter PvP with another player
  5. Summon skeletons and observe the damage they deal when attacking as well as exploding (these can be done separately).
  6. Default attack the opponent until you land a hit and repeat step 6.
  7. They should deal triple damage when default attacking, but do the same damage when exploding.
Character build code
https://pastebin.com/7eErJ0tL
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the supplied Path of Building build code and following the Minion Instability damage calculation described in the reproduction steps. Compare its treatment of cast rate and The Iron Mass's conditional with the expected on-death behavior. Done means the explosion damage is independent of attack/cast rate and weapon-hit conditional damage, while ordinary attacks retain those effects.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.