PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Modifiers to damage of exerted attacks do not modify ailment damage for General's Cry
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
When allocating passives that increase the damage of exerted attacks, both hit damage and ailment damage of attacks dealt by General's Cry mirages should be increased.
What is the actual behaviour/value?
Ailment damage is not increased for attacks dealt by General's Cry mirages.
This can be worked around by adding another warcry, such as Seismic Cry, and choosing Max Hit calculation mode, however this causes those increases to apply to hit damage twice.
How to reproduce the issue
- Select Tectonic Slam as main skill.
- Link General's Cry
- Equip a weapon that has any chance to crit
- View the tooltip of the Exerted Attack Damage passives, or the Warcry mastery that provides that mod
- Ignite damage is unaffected
- Add Seismic Cry as an additional skill
- Enable Max Hit calculation mode
- View the passive tooltip again
- Ignite damage is increased as much as hit damage was previously
- Hit damage is increased twise as much as before
Character build code
https://pastebin.com/cymZpvNP
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza importando la build de personaje de Path of Building proporcionada y reproduce el problema con Tectonic Slam vinculado a General's Cry. Compara el daño de las alteraciones y el daño de impacto con las pasivas de daño de ataques exerted, y repite la prueba con Seismic Cry y el modo de cálculo Max Hit; se considera terminado cuando esos modificadores afectan al daño de las alteraciones sin aplicarse dos veces al daño de impacto.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- game-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100