PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Modifiers to damage of exerted attacks do not modify ailment damage for General's Cry

Open
#4,513 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: behaviour
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

When allocating passives that increase the damage of exerted attacks, both hit damage and ailment damage of attacks dealt by General's Cry mirages should be increased.

What is the actual behaviour/value?

Ailment damage is not increased for attacks dealt by General's Cry mirages.

This can be worked around by adding another warcry, such as Seismic Cry, and choosing Max Hit calculation mode, however this causes those increases to apply to hit damage twice.

How to reproduce the issue
  1. Select Tectonic Slam as main skill.
  2. Link General's Cry
  3. Equip a weapon that has any chance to crit
  4. View the tooltip of the Exerted Attack Damage passives, or the Warcry mastery that provides that mod
  5. Ignite damage is unaffected
  6. Add Seismic Cry as an additional skill
  7. Enable Max Hit calculation mode
  8. View the passive tooltip again
  9. Ignite damage is increased as much as hit damage was previously
  10. Hit damage is increased twise as much as before
Character build code
https://pastebin.com/cymZpvNP
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by importing the provided Path of Building character build and reproducing the issue with Tectonic Slam linked to General's Cry. Compare ailment and hit damage with the exerted attack damage passives, then repeat with Seismic Cry and Max Hit calculation mode; done means those modifiers affect ailment damage without applying twice to hit damage.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.