PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Rallying cry and intimidating cry causing off hand damage to be more than mainhand
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Rallying cry and intimidating cry should have the same effect on main hand damage as they do offhand damage
What is the actual behaviour/value?
Enabling rallying cry or intimidating cry with identical weapons equiped causes off hand damage to be higher than main hand dmg. The increases/reductions and %more calculations under mainhand damage and off hand damage change to values that are not equal to each other.
How to reproduce the issue
Use chieftain tree in provided pob
0. Equip identical weapons to make comparison easier
- Disable rallying cry and intimidating cry
- Look at main hand and offhand damage in calc tab not
- Enable rallying cry and or intimidating cry
- Look at calc tab and see difference in main and off hand damage exists but is small
- Switch to berserker tree in provided pob and repeat steps 1-3
- Look at calc tab and see that offhand damage is now 1.5 times mainhand damage.
Build code
https://pastebin.com/t8qiPXJQ
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by loading the provided build code and reproducing the discrepancy in the Calc tab with identical weapons, first on the Chieftain tree and then on the Berserker tree. Trace the Rallying Cry and Intimidating Cry calculations for main-hand and off-hand damage. Done means identical weapons produce equivalent main-hand and off-hand effects when either cry is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100