PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Avg Dmg Effect of Exerting Warcries provides a misleading number that has no actual build meaning due to ignoring pre-existing increased damage, when having increased damage with exerted attacks

オープン
#3,169 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

bug
主要言語
Lua
スター
5.4k
フォーク
2.4k
平均マージ
1日 12時間
マージ済み PR(30日)
26

説明

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Avg Dmg Effect of Exerting Warcries section under Calcs should show me the multiplier to damage compared to non-Exerted Attacks.

What is the actual behaviour/value?

Avg Dmg Effect displays a meaningless number in any scenario where a character has increased damage with exerted attacks, and any other source of increased damage.

See https://www.pathofexile.com/forum/view-thread/3170919

The Avg Dmg Effect treats increased damage with exerted attacks as though it were an independent multiplier. However, this does not take into account any pre-existing increased damage, which means that at no point does the Avg Dmg Effect accurately represent any meaningful DPS effect (within the game nor within POB Total DPS).

The most meaningful number to replace this with would be the proportional damage multiplier resulting from the additional increased damage (aka the "more damage" of the increased damage). See "How to reproduce the issue" for a specific example.

How to reproduce the issue
  1. Load https://pastebin.com/b4LZ9vJt
  2. Click to "Calcs"
  3. Select skill "Rage Vortex"
  4. Avg Dmg Effect of the Exerting Warcries section calculates 2.55, which is 1.7 * 1.5, or increased damage multiplier of exerted attacks * more damage multiplier of exerted attacks.
  5. 2.55 is not a meaningful number, because the proportional DPS effect of the increased damage multiplier is less than 1.7, due to the pre-existing increased damage bonuses.
  6. The most meaningful number to replace this with would be 1.7244, which is the actual DPS multiplier resulting from the marginal increased damage bonus (4.68 + 0.70)/4.68 = 1.1496, times the DPS multiplier resulting from more damage 1.5 = 1.7244.
Build code
https://pastebin.com/b4LZ9vJt
Screenshots

No response

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

CalcsビューでAvg Dmg Effect of the Exerting Warcriesセクションから始め、リンクされたPastebinビルドを使ってRage Vortexの例を再現します。increased damageとmore damageがどのように組み合わされるかを追跡します。表示された結果が、報告された例における約1.7244の限界DPS倍率を反映すれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
lua
領域
desktop
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。