PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Avg Dmg Effect of Exerting Warcries provides a misleading number that has no actual build meaning due to ignoring pre-existing increased damage, when having increased damage with exerted attacks
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Avg Dmg Effect of Exerting Warcries section under Calcs should show me the multiplier to damage compared to non-Exerted Attacks.
What is the actual behaviour/value?
Avg Dmg Effect displays a meaningless number in any scenario where a character has increased damage with exerted attacks, and any other source of increased damage.
See https://www.pathofexile.com/forum/view-thread/3170919
The Avg Dmg Effect treats increased damage with exerted attacks as though it were an independent multiplier. However, this does not take into account any pre-existing increased damage, which means that at no point does the Avg Dmg Effect accurately represent any meaningful DPS effect (within the game nor within POB Total DPS).
The most meaningful number to replace this with would be the proportional damage multiplier resulting from the additional increased damage (aka the "more damage" of the increased damage). See "How to reproduce the issue" for a specific example.
How to reproduce the issue
- Load https://pastebin.com/b4LZ9vJt
- Click to "Calcs"
- Select skill "Rage Vortex"
- Avg Dmg Effect of the Exerting Warcries section calculates 2.55, which is 1.7 * 1.5, or increased damage multiplier of exerted attacks * more damage multiplier of exerted attacks.
- 2.55 is not a meaningful number, because the proportional DPS effect of the increased damage multiplier is less than 1.7, due to the pre-existing increased damage bonuses.
- The most meaningful number to replace this with would be 1.7244, which is the actual DPS multiplier resulting from the marginal increased damage bonus (4.68 + 0.70)/4.68 = 1.1496, times the DPS multiplier resulting from more damage 1.5 = 1.7244.
Build code
https://pastebin.com/b4LZ9vJt
Screenshots
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne in der Calcs-Ansicht mit dem Abschnitt Avg Dmg Effect of the Exerting Warcries und reproduziere das Rage Vortex-Beispiel anhand des verlinkten Pastebin-Builds. Verfolge, wie increased damage und more damage kombiniert werden; abgeschlossen ist die Aufgabe, wenn das angezeigte Ergebnis den marginalen DPS-Multiplikator widerspiegelt, ungefähr 1.7244 für das gemeldete Beispiel.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- desktop
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100