PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Avg Dmg Effect of Exerting Warcries provides a misleading number that has no actual build meaning due to ignoring pre-existing increased damage, when having increased damage with exerted attacks

Aperta
#3,169 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Avg Dmg Effect of Exerting Warcries section under Calcs should show me the multiplier to damage compared to non-Exerted Attacks.

What is the actual behaviour/value?

Avg Dmg Effect displays a meaningless number in any scenario where a character has increased damage with exerted attacks, and any other source of increased damage.

See https://www.pathofexile.com/forum/view-thread/3170919

The Avg Dmg Effect treats increased damage with exerted attacks as though it were an independent multiplier. However, this does not take into account any pre-existing increased damage, which means that at no point does the Avg Dmg Effect accurately represent any meaningful DPS effect (within the game nor within POB Total DPS).

The most meaningful number to replace this with would be the proportional damage multiplier resulting from the additional increased damage (aka the "more damage" of the increased damage). See "How to reproduce the issue" for a specific example.

How to reproduce the issue
  1. Load https://pastebin.com/b4LZ9vJt
  2. Click to "Calcs"
  3. Select skill "Rage Vortex"
  4. Avg Dmg Effect of the Exerting Warcries section calculates 2.55, which is 1.7 * 1.5, or increased damage multiplier of exerted attacks * more damage multiplier of exerted attacks.
  5. 2.55 is not a meaningful number, because the proportional DPS effect of the increased damage multiplier is less than 1.7, due to the pre-existing increased damage bonuses.
  6. The most meaningful number to replace this with would be 1.7244, which is the actual DPS multiplier resulting from the marginal increased damage bonus (4.68 + 0.70)/4.68 = 1.1496, times the DPS multiplier resulting from more damage 1.5 = 1.7244.
Build code
https://pastebin.com/b4LZ9vJt
Screenshots

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia nella vista Calcs con la sezione Avg Dmg Effect of the Exerting Warcries e riproduci l'esempio di Rage Vortex usando la build Pastebin collegata. Traccia come vengono combinati increased damage e more damage; il lavoro è completato quando il risultato visualizzato riflette il moltiplicatore DPS marginale, circa 1.7244 per l'esempio riportato.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
desktop
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.