PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Avg Dmg Effect of Exerting Warcries provides a misleading number that has no actual build meaning due to ignoring pre-existing increased damage, when having increased damage with exerted attacks

Ouverte
#3,169 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

bug
Langage dominant
Lua
Étoiles
5.4k
Forks
2.4k
Merge moyen
1 j 12 h
PR mergées (30 j)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Avg Dmg Effect of Exerting Warcries section under Calcs should show me the multiplier to damage compared to non-Exerted Attacks.

What is the actual behaviour/value?

Avg Dmg Effect displays a meaningless number in any scenario where a character has increased damage with exerted attacks, and any other source of increased damage.

See https://www.pathofexile.com/forum/view-thread/3170919

The Avg Dmg Effect treats increased damage with exerted attacks as though it were an independent multiplier. However, this does not take into account any pre-existing increased damage, which means that at no point does the Avg Dmg Effect accurately represent any meaningful DPS effect (within the game nor within POB Total DPS).

The most meaningful number to replace this with would be the proportional damage multiplier resulting from the additional increased damage (aka the "more damage" of the increased damage). See "How to reproduce the issue" for a specific example.

How to reproduce the issue
  1. Load https://pastebin.com/b4LZ9vJt
  2. Click to "Calcs"
  3. Select skill "Rage Vortex"
  4. Avg Dmg Effect of the Exerting Warcries section calculates 2.55, which is 1.7 * 1.5, or increased damage multiplier of exerted attacks * more damage multiplier of exerted attacks.
  5. 2.55 is not a meaningful number, because the proportional DPS effect of the increased damage multiplier is less than 1.7, due to the pre-existing increased damage bonuses.
  6. The most meaningful number to replace this with would be 1.7244, which is the actual DPS multiplier resulting from the marginal increased damage bonus (4.68 + 0.70)/4.68 = 1.1496, times the DPS multiplier resulting from more damage 1.5 = 1.7244.
Build code
https://pastebin.com/b4LZ9vJt
Screenshots

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez dans la vue Calcs avec la section Avg Dmg Effect of the Exerting Warcries et reproduisez l’exemple Rage Vortex en utilisant le build Pastebin associé. Suivez la manière dont increased damage et more damage sont combinés ; le travail est terminé lorsque le résultat affiché reflète le multiplicateur de DPS marginal, environ 1.7244 pour l’exemple indiqué.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
lua
Domaine
desktop
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.