PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Report about increased critical chance during flask effect
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Thank you for reporting an issue.
Before reporting a bug, please make sure that you are running the latest version.
You can get the latest version number from CHANGELOG.md
Please try to fill in as much of the template below as you're able.
-
What happened?
usually, increased critical chance during flask effect only work one, but in pob
2 flask of them work all. so increasing critical chance, but ingame critical chance don't work like that -
What were you trying to do?
using all kind of flask -
What steps will reproduce the bug?
maybe, If only one applies, the flask option must be changed so that only one applies. -
Screenshots:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported critical-chance behavior with multiple flask effects enabled and compare it with the stated in-game behavior. Trace the flask-effect handling in the Lua code; done means the planner applies the same critical-chance rule as the game and the relevant behavior is covered by a regression check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100