PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Mirages should not use character action speed

Open
#2,418 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

  • What happened?
    Modifiers to character action speed affect Attack Rate of skills used by Mirages. They shouldn't.

Action speed is an object-level stat; it is not checked on your skill. If your character is chilled, it does not slow down your totems/mirages. If your character has Tailwind, it does not speed up your totems/mirages. (Though Deadeye's Gathering Winds can give allies their own Tailwind.)

This is currently handled correctly for totems, but incorrectly for Mirage Archers, Mirage Saviours, and General's Cry Mirage Warriors.

  • What were you trying to do?
    Checking new features.

  • What steps will reproduce the bug?
    Use Mirage Archer Support / General's Cry Support / The Saviour with a compatible skill and weapon. Add Tailwind boots. Check 'Are you Chilled' or 'Do you have Tailwind' in Configurations. These should not affect Mirage Attack Rate, but currently do.

  • Does it reproduce every time?
    Yes.

  • Provide a build code:
    https://pastebin.com/QLBNDbbM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided Path of Building build code using Mirage Archer Support, General's Cry Support, or The Saviour, then compare attack-rate calculations for these mirages with the existing totem behavior. Check the Tailwind and chilled configuration states, and consider the issue complete when those character action-speed modifiers no longer change Mirage attack rate.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.