PEtab-dev / PEtab-dev/libpetab-python

Improve model abstractions

未關閉
#518 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

主要語言
Python
星號
18
分支
9
PR 合併指標
30 天內沒有已合併 PR

描述

The current model abstraction in petab.v1.models.model.Model isn't great. Non-exhaustive list of problems:

  • We don't have proper handling of derived parameters (#517 / https://github.com/PEtab-dev/libpetab-python/pull/517#issuecomment-5566488336)
  • is_state_variable conflates different questions. The simulator decides what's treated as a state variable - that's none of PEtab's business.
  • Ideally, the library would more closely adopt the specs' taxonomy regarding constant, differential, and algebraic entities.

Improve that. This will probably impact quite a number of places and needs to be addressed carefully.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

Start by reading petab.v1.models.model.Model and the discussion in #517, including the linked pull request comment. Map how derived parameters and is_state_variable are used across the package before proposing changes. Done means the model abstraction reflects the constant, differential, and algebraic taxonomy without conflating simulator decisions.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
tooling
Issue 類型
重構
難度
5/5
預估耗時
一週以上
活躍度
活躍
描述清晰度
需要釐清
新手友好度
25/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。