PEtab-dev / PEtab-dev/libpetab-python

Improve model abstractions

未关闭
#518 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Python
星标
18
派生
9
PR 合并指标
30 天内没有已合并 PR

描述

The current model abstraction in petab.v1.models.model.Model isn't great. Non-exhaustive list of problems:

  • We don't have proper handling of derived parameters (#517 / https://github.com/PEtab-dev/libpetab-python/pull/517#issuecomment-5566488336)
  • is_state_variable conflates different questions. The simulator decides what's treated as a state variable - that's none of PEtab's business.
  • Ideally, the library would more closely adopt the specs' taxonomy regarding constant, differential, and algebraic entities.

Improve that. This will probably impact quite a number of places and needs to be addressed carefully.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

Start by reading petab.v1.models.model.Model and the discussion in #517, including the linked pull request comment. Map how derived parameters and is_state_variable are used across the package before proposing changes. Done means the model abstraction reflects the constant, differential, and algebraic taxonomy without conflating simulator decisions.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
tooling
Issue 类型
重构
难度
5/5
预计耗时
一周以上
活跃度
活跃
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。