NativeScript / NativeScript/nativescript-cli
CLI 8.2.x discards AAR files with the same name
まだ誰も着手していません。
- 主要言語
- JavaScript
- スター
- 1.1k
- フォーク
- 204
- 平均マージ
- 1日 9時間
- マージ済み PR(30日)
- 8
説明
Issue Description
I have a plugin workspace with multiple packages and a core package, all under the same scope. My core package has a platforms folder, with an AndroidManifest.xml and an include.gradle file.
Starting from CLI 8.2.x (with 8.1.x works fine) I've noticed that some permissions were missing after building the app, permissions declared in the AndroidManifest.xml of my plugin. It turns out that on build time, an aar is being generated for my core package called core.aar. So, the file name seems to collide with another package (probably the one from @nativescript/core) hence being discarded.
I see the need of discarding duplicated aar files, but perhaps the process should be a bit more "smart" and consider where those files are placed. That, or generated aar files for scoped plugins should contain the scope on its name. These are some suggestions, in case they help.
Reproduction
- Find or create a plugin workspace with a package named
core. - Add an AndroidManifest.xml file to the
platforms/androidfolder of the plugin. - Add some permission to the manifest (any other thing would work too, but a permission is the easiest thing to add).
- Pack the plugin and install inside an existing app.
- Build the app.
- Check if the permission is listed under the information page of the app.
Relevant log output (if applicable)
No response
Environment
OS: macOS 12.2.1
CPU: (8) arm64 Apple M1
Shell: /bin/zsh
node: 16.13.1
npm: 8.3.2
nativescript: 8.2.3
# android
java: 11.0.11
ndk: Not Found
apis: 23, 26, 28, 29, 30, 31, 32
build_tools: 28.0.3, 29.0.0, 30.0.3, 31.0.0, 32.0.0
system_images:
- android-31 | Google Play ARM 64 v8a
- android-32 | Google Play ARM 64 v8a
# ios
xcode: 13.3.1/13E500a
cocoapods: 1.11.2
python: 2.7.18
python3: 3.8.9
ruby: 2.6.8
platforms:
- DriverKit 21.4
- iOS 15.4
- macOS 12.3
- tvOS 15.4
- watchOS 8.5
Dependencies
"dependencies": {
"@awarns/core": "file:../../packages/core",
"@nativescript/core": "file:../../node_modules/@nativescript/core",
"@nativescript/unit-test-runner": "^3.0.3",
"@awarns/geofencing": "file:../../packages/geofencing"
},
"devDependencies": {
"@jsdevtools/coverage-istanbul-loader": "3.0.5",
"@nativescript/android": "~8.2.0",
"@nativescript/ios": "~8.2.0",
"karma": "6.3.17",
"karma-coverage": "2.0.3",
"karma-jasmine": "4.0.1",
"karma-junit-reporter": "2.0.1",
"karma-nativescript-launcher": "0.4.0",
"nyc": "15.1.0"
}
Please accept these terms
- I have searched the existing issues as well as StackOverflow and this has not been posted before
- This is a bug report
- I agree to follow this project's Code of Conduct
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
platforms/android/AndroidManifest.xml と include.gradle を含むプラグインを使ってビルドを再現し、その後、CLI による生成済み AAR ファイルの処理を追跡します。CLI 8.1.x と 8.2.x の動作を比較し、同名のアーティファクトがどこで破棄されるのかを特定します。プラグインの manifest の権限がビルドされたアプリに残り、重複アーティファクトの処理を壊さないことが完了条件です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- android, javascript
- 領域
- build-system, cli, mobile-dev
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 42/100