NativeScript / NativeScript/nativescript-cli

CLI 8.2.x discards AAR files with the same name

未關閉
#5,665 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

bug
主要語言
JavaScript
星號
1.1k
分支
204
平均合併
1 天 9 小時
30 天內合併 PR
8

描述

Issue Description

I have a plugin workspace with multiple packages and a core package, all under the same scope. My core package has a platforms folder, with an AndroidManifest.xml and an include.gradle file.

Starting from CLI 8.2.x (with 8.1.x works fine) I've noticed that some permissions were missing after building the app, permissions declared in the AndroidManifest.xml of my plugin. It turns out that on build time, an aar is being generated for my core package called core.aar. So, the file name seems to collide with another package (probably the one from @nativescript/core) hence being discarded.

I see the need of discarding duplicated aar files, but perhaps the process should be a bit more "smart" and consider where those files are placed. That, or generated aar files for scoped plugins should contain the scope on its name. These are some suggestions, in case they help.

Reproduction
  1. Find or create a plugin workspace with a package named core.
  2. Add an AndroidManifest.xml file to the platforms/android folder of the plugin.
  3. Add some permission to the manifest (any other thing would work too, but a permission is the easiest thing to add).
  4. Pack the plugin and install inside an existing app.
  5. Build the app.
  6. Check if the permission is listed under the information page of the app.
Relevant log output (if applicable)

No response

Environment
OS: macOS 12.2.1
CPU: (8) arm64 Apple M1
Shell: /bin/zsh
node: 16.13.1
npm: 8.3.2
nativescript: 8.2.3

# android
java: 11.0.11
ndk: Not Found
apis: 23, 26, 28, 29, 30, 31, 32
build_tools: 28.0.3, 29.0.0, 30.0.3, 31.0.0, 32.0.0
system_images:
  - android-31 | Google Play ARM 64 v8a
  - android-32 | Google Play ARM 64 v8a

# ios
xcode: 13.3.1/13E500a
cocoapods: 1.11.2
python: 2.7.18
python3: 3.8.9
ruby: 2.6.8
platforms:
  - DriverKit 21.4
  - iOS 15.4
  - macOS 12.3
  - tvOS 15.4
  - watchOS 8.5
Dependencies
"dependencies": {
  "@awarns/core": "file:../../packages/core",
  "@nativescript/core": "file:../../node_modules/@nativescript/core",
  "@nativescript/unit-test-runner": "^3.0.3",
  "@awarns/geofencing": "file:../../packages/geofencing"
},
"devDependencies": {
  "@jsdevtools/coverage-istanbul-loader": "3.0.5",
  "@nativescript/android": "~8.2.0",
  "@nativescript/ios": "~8.2.0",
  "karma": "6.3.17",
  "karma-coverage": "2.0.3",
  "karma-jasmine": "4.0.1",
  "karma-junit-reporter": "2.0.1",
  "karma-nativescript-launcher": "0.4.0",
  "nyc": "15.1.0"
}
Please accept these terms

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

使用包含 platforms/android/AndroidManifest.xml 和 include.gradle 的外掛程式重現建置,然後追蹤 CLI 對產生的 AAR 檔案的處理方式。比較 CLI 8.1.x 和 8.2.x 的行為,並找出同名 artifact 在哪裡遭到捨棄。完成條件是:外掛程式 manifest 中的權限保留在建置出的應用程式中,同時不破壞重複 artifact 的處理。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
android, javascript
領域
build-system, cli, mobile-dev
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。