NativeScript / NativeScript/nativescript-cli

CLI 8.2.x discards AAR files with the same name

Aberta
#5,665 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

bug
Linguagem predominante
JavaScript
Estrelas
1.1k
Forks
204
Merge médio
1d 9h
PRs com merge (30d)
8

Descrição

Issue Description

I have a plugin workspace with multiple packages and a core package, all under the same scope. My core package has a platforms folder, with an AndroidManifest.xml and an include.gradle file.

Starting from CLI 8.2.x (with 8.1.x works fine) I've noticed that some permissions were missing after building the app, permissions declared in the AndroidManifest.xml of my plugin. It turns out that on build time, an aar is being generated for my core package called core.aar. So, the file name seems to collide with another package (probably the one from @nativescript/core) hence being discarded.

I see the need of discarding duplicated aar files, but perhaps the process should be a bit more "smart" and consider where those files are placed. That, or generated aar files for scoped plugins should contain the scope on its name. These are some suggestions, in case they help.

Reproduction
  1. Find or create a plugin workspace with a package named core.
  2. Add an AndroidManifest.xml file to the platforms/android folder of the plugin.
  3. Add some permission to the manifest (any other thing would work too, but a permission is the easiest thing to add).
  4. Pack the plugin and install inside an existing app.
  5. Build the app.
  6. Check if the permission is listed under the information page of the app.
Relevant log output (if applicable)

No response

Environment
OS: macOS 12.2.1
CPU: (8) arm64 Apple M1
Shell: /bin/zsh
node: 16.13.1
npm: 8.3.2
nativescript: 8.2.3

# android
java: 11.0.11
ndk: Not Found
apis: 23, 26, 28, 29, 30, 31, 32
build_tools: 28.0.3, 29.0.0, 30.0.3, 31.0.0, 32.0.0
system_images:
  - android-31 | Google Play ARM 64 v8a
  - android-32 | Google Play ARM 64 v8a

# ios
xcode: 13.3.1/13E500a
cocoapods: 1.11.2
python: 2.7.18
python3: 3.8.9
ruby: 2.6.8
platforms:
  - DriverKit 21.4
  - iOS 15.4
  - macOS 12.3
  - tvOS 15.4
  - watchOS 8.5
Dependencies
"dependencies": {
  "@awarns/core": "file:../../packages/core",
  "@nativescript/core": "file:../../node_modules/@nativescript/core",
  "@nativescript/unit-test-runner": "^3.0.3",
  "@awarns/geofencing": "file:../../packages/geofencing"
},
"devDependencies": {
  "@jsdevtools/coverage-istanbul-loader": "3.0.5",
  "@nativescript/android": "~8.2.0",
  "@nativescript/ios": "~8.2.0",
  "karma": "6.3.17",
  "karma-coverage": "2.0.3",
  "karma-jasmine": "4.0.1",
  "karma-junit-reporter": "2.0.1",
  "karma-nativescript-launcher": "0.4.0",
  "nyc": "15.1.0"
}
Please accept these terms

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Direção de pesquisa

Reproduza o build usando um plugin com platforms/android/AndroidManifest.xml e include.gradle e, em seguida, rastreie como a CLI lida com os arquivos AAR gerados. Compare o comportamento da CLI 8.1.x e 8.2.x e identifique onde os artefatos com o mesmo nome são descartados. O trabalho estará concluído quando as permissões do manifest do plugin permanecerem no aplicativo compilado sem quebrar o tratamento de artefatos duplicados.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
android, javascript
Domínio
build-system, cli, mobile-dev
Tipo de issue
Bug
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
42/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.