NativeScript / NativeScript/nativescript-cli

CLI 8.2.x discards AAR files with the same name

Ouverte
#5,665 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

bug
Langage dominant
JavaScript
Étoiles
1.1k
Forks
204
Merge moyen
1 j 9 h
PR mergées (30 j)
8

Description

Issue Description

I have a plugin workspace with multiple packages and a core package, all under the same scope. My core package has a platforms folder, with an AndroidManifest.xml and an include.gradle file.

Starting from CLI 8.2.x (with 8.1.x works fine) I've noticed that some permissions were missing after building the app, permissions declared in the AndroidManifest.xml of my plugin. It turns out that on build time, an aar is being generated for my core package called core.aar. So, the file name seems to collide with another package (probably the one from @nativescript/core) hence being discarded.

I see the need of discarding duplicated aar files, but perhaps the process should be a bit more "smart" and consider where those files are placed. That, or generated aar files for scoped plugins should contain the scope on its name. These are some suggestions, in case they help.

Reproduction
  1. Find or create a plugin workspace with a package named core.
  2. Add an AndroidManifest.xml file to the platforms/android folder of the plugin.
  3. Add some permission to the manifest (any other thing would work too, but a permission is the easiest thing to add).
  4. Pack the plugin and install inside an existing app.
  5. Build the app.
  6. Check if the permission is listed under the information page of the app.
Relevant log output (if applicable)

No response

Environment
OS: macOS 12.2.1
CPU: (8) arm64 Apple M1
Shell: /bin/zsh
node: 16.13.1
npm: 8.3.2
nativescript: 8.2.3

# android
java: 11.0.11
ndk: Not Found
apis: 23, 26, 28, 29, 30, 31, 32
build_tools: 28.0.3, 29.0.0, 30.0.3, 31.0.0, 32.0.0
system_images:
  - android-31 | Google Play ARM 64 v8a
  - android-32 | Google Play ARM 64 v8a

# ios
xcode: 13.3.1/13E500a
cocoapods: 1.11.2
python: 2.7.18
python3: 3.8.9
ruby: 2.6.8
platforms:
  - DriverKit 21.4
  - iOS 15.4
  - macOS 12.3
  - tvOS 15.4
  - watchOS 8.5
Dependencies
"dependencies": {
  "@awarns/core": "file:../../packages/core",
  "@nativescript/core": "file:../../node_modules/@nativescript/core",
  "@nativescript/unit-test-runner": "^3.0.3",
  "@awarns/geofencing": "file:../../packages/geofencing"
},
"devDependencies": {
  "@jsdevtools/coverage-istanbul-loader": "3.0.5",
  "@nativescript/android": "~8.2.0",
  "@nativescript/ios": "~8.2.0",
  "karma": "6.3.17",
  "karma-coverage": "2.0.3",
  "karma-jasmine": "4.0.1",
  "karma-junit-reporter": "2.0.1",
  "karma-nativescript-launcher": "0.4.0",
  "nyc": "15.1.0"
}
Please accept these terms

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Reproduisez le build à l’aide d’un plugin contenant platforms/android/AndroidManifest.xml et include.gradle, puis suivez le traitement par la CLI des fichiers AAR générés. Comparez le comportement de CLI 8.1.x et 8.2.x et identifiez à quel endroit les artefacts portant le même nom sont écartés. La tâche est terminée lorsque les permissions du manifest du plugin restent présentes dans l’application générée sans perturber la gestion des artefacts en double.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
android, javascript
Domaine
build-system, cli, mobile-dev
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
42/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.