ISISComputingGroup / ISISComputingGroup/IBEX

Beckhoff: Engineering units are left at microns by default

オープン
#6,855 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
awaiting
主要言語
言語のデータがありません
スター
6
フォーク
2
平均マージ
16時間 40分
マージ済み PR(30日)
2

説明

As a scientist I would like my Beckhoff to tell me what its engineering units are through IBEX. I identified when commissioning LARMOR that the units for the system were incorrect. The units should be `deg` for LARMOR as it's a rotating bench, however by default we display `um` as the EGU. We should talk to the motion team about how we can add this functionality.

### Acceptance Criteria
_What is the acceptance criteria?_
- [ ] A discussion is had between us and the motion team about adding this functionality.
- [ ] Changes are implemented in tcioc for the units info to propagate to each axis (units may also be different per axis?)
- [ ] Tests are added to make sure this info is propagated correctly

### Extra Information
This information currently isn't stored in the status struct, or subsequently the .tpy file. It may be best to add these through the global struct instead, for example how nAXIS_NUM is added (even though we don't currently use it!)

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

Start by reviewing tcioc and how the status struct, .tpy data, and global struct expose values such as nAXIS_NUM. Discuss the units propagation design with the motion team, including whether units differ by axis. Done means engineering units reach each axis and tests verify the propagated information.

索引モデルが issue の本文から書いたものです。

評価

領域
embedded-iot
issue の種類
機能追加
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
30/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。