ISISComputingGroup / ISISComputingGroup/IBEX

Beckhoff: Engineering units are left at microns by default

Offen
#6,855 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
awaiting
Vorherrschende Sprache
Keine Sprachdaten
Sterne
6
Forks
2
Ø Merge
16 Std. 40 Min.
Gemergte PRs (30 T.)
2

Beschreibung

As a scientist I would like my Beckhoff to tell me what its engineering units are through IBEX. I identified when commissioning LARMOR that the units for the system were incorrect. The units should be `deg` for LARMOR as it's a rotating bench, however by default we display `um` as the EGU. We should talk to the motion team about how we can add this functionality.

### Acceptance Criteria
_What is the acceptance criteria?_
- [ ] A discussion is had between us and the motion team about adding this functionality.
- [ ] Changes are implemented in tcioc for the units info to propagate to each axis (units may also be different per axis?)
- [ ] Tests are added to make sure this info is propagated correctly

### Extra Information
This information currently isn't stored in the status struct, or subsequently the .tpy file. It may be best to add these through the global struct instead, for example how nAXIS_NUM is added (even though we don't currently use it!)

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start by reviewing tcioc and how the status struct, .tpy data, and global struct expose values such as nAXIS_NUM. Discuss the units propagation design with the motion team, including whether units differ by axis. Done means engineering units reach each axis and tests verify the propagated information.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Bereich
embedded-iot
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
30/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.