ISISComputingGroup / ISISComputingGroup/IBEX

Beckhoff: Engineering units are left at microns by default

Abierto
#6,855 2 comentarios 0 reacciones 0 asignados Ver en GitHub
awaiting
Lenguaje dominante
Sin datos de lenguaje
Estrellas
6
Forks
2
Merge medio
16 h 40 min
PR fusionados (30 d)
2

Descripción

As a scientist I would like my Beckhoff to tell me what its engineering units are through IBEX. I identified when commissioning LARMOR that the units for the system were incorrect. The units should be `deg` for LARMOR as it's a rotating bench, however by default we display `um` as the EGU. We should talk to the motion team about how we can add this functionality.

### Acceptance Criteria
_What is the acceptance criteria?_
- [ ] A discussion is had between us and the motion team about adding this functionality.
- [ ] Changes are implemented in tcioc for the units info to propagate to each axis (units may also be different per axis?)
- [ ] Tests are added to make sure this info is propagated correctly

### Extra Information
This information currently isn't stored in the status struct, or subsequently the .tpy file. It may be best to add these through the global struct instead, for example how nAXIS_NUM is added (even though we don't currently use it!)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start by reviewing tcioc and how the status struct, .tpy data, and global struct expose values such as nAXIS_NUM. Discuss the units propagation design with the motion team, including whether units differ by axis. Done means engineering units reach each axis and tests verify the propagated information.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Área
embedded-iot
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
30/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.