ISISComputingGroup / ISISComputingGroup/IBEX

Beckhoff: Engineering units are left at microns by default

Aperta
#6,855 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
awaiting
Lingua principale
Nessun dato sulla lingua
Stelle
6
Fork
2
Merge medio
16h 40m
PR unite (30g)
2

Descrizione

As a scientist I would like my Beckhoff to tell me what its engineering units are through IBEX. I identified when commissioning LARMOR that the units for the system were incorrect. The units should be `deg` for LARMOR as it's a rotating bench, however by default we display `um` as the EGU. We should talk to the motion team about how we can add this functionality.

### Acceptance Criteria
_What is the acceptance criteria?_
- [ ] A discussion is had between us and the motion team about adding this functionality.
- [ ] Changes are implemented in tcioc for the units info to propagate to each axis (units may also be different per axis?)
- [ ] Tests are added to make sure this info is propagated correctly

### Extra Information
This information currently isn't stored in the status struct, or subsequently the .tpy file. It may be best to add these through the global struct instead, for example how nAXIS_NUM is added (even though we don't currently use it!)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.