ESCOMP / ESCOMP/CMEPS

Calling shr_wv_sat_init() from mediator rather than driver?

オープン
#653 コメント 5 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Fortran
スター
35
フォーク
106
平均マージ
6日 12時間
マージ済み PR(30日)
5

説明

The [`shr_wv_sat_init()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/driver/esm.F90#L526) call is required to to use [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) routine and similar ones to calculate the saturation mixing ratio from the tables but the current implementation assumes that the CMEPS flux calculation will be only used by CESM and its driver. Since we are coupling MPAS and MOM6 outside of the CESM framework (at this point) through ESMX driver, the [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) call returns all zero and flux calculation is messed up. As I see those codes are under driver and it makes sense but I think moving those outside of the driver code and init through the `med.F90` rather then `esm.F90` would make it more generic and it could be also used by UFS WM (I did not check their driver has this init call or not yet) and other projects like ours.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。