ESCOMP / ESCOMP/CMEPS

Calling shr_wv_sat_init() from mediator rather than driver?

未關閉
#653 5 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Fortran
星號
35
分支
106
平均合併
5 天 15 小時
30 天內合併 PR
6

描述

The [`shr_wv_sat_init()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/driver/esm.F90#L526) call is required to to use [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) routine and similar ones to calculate the saturation mixing ratio from the tables but the current implementation assumes that the CMEPS flux calculation will be only used by CESM and its driver. Since we are coupling MPAS and MOM6 outside of the CESM framework (at this point) through ESMX driver, the [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) call returns all zero and flux calculation is messed up. As I see those codes are under driver and it makes sense but I think moving those outside of the driver code and init through the `med.F90` rather then `esm.F90` would make it more generic and it could be also used by UFS WM (I did not check their driver has this init call or not yet) and other projects like ours.

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

首先比較 cesm/driver/esm.F90 中的 shr_wv_sat_init() 呼叫與 cesm/flux_atmocn/flux_atmocn_Large.F90 中對 shr_wv_sat_qsat_liquid() 的使用,然後檢查 med.F90 的初始化。確認該初始化可透過 mediator 用於 ESMX 耦合,並確認飽和混合比值在通量計算期間不再為零。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
fortran
領域
backend
Issue 類型
重構
難度
4/5
預估耗時
3-5 天
活躍度
冷清
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。