ESCOMP / ESCOMP/CMEPS

Calling shr_wv_sat_init() from mediator rather than driver?

Offen
#653 5 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Fortran
Sterne
35
Forks
106
Ø Merge
6 T. 12 Std.
Gemergte PRs (30 T.)
5

Beschreibung

The [`shr_wv_sat_init()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/driver/esm.F90#L526) call is required to to use [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) routine and similar ones to calculate the saturation mixing ratio from the tables but the current implementation assumes that the CMEPS flux calculation will be only used by CESM and its driver. Since we are coupling MPAS and MOM6 outside of the CESM framework (at this point) through ESMX driver, the [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) call returns all zero and flux calculation is messed up. As I see those codes are under driver and it makes sense but I think moving those outside of the driver code and init through the `med.F90` rather then `esm.F90` would make it more generic and it could be also used by UFS WM (I did not check their driver has this init call or not yet) and other projects like ours.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.