ESCOMP / ESCOMP/CMEPS

Calling shr_wv_sat_init() from mediator rather than driver?

未关闭
#653 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Fortran
星标
35
派生
106
平均合并
6 天 12 小时
30 天内合并 PR
5

描述

The [`shr_wv_sat_init()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/driver/esm.F90#L526) call is required to to use [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) routine and similar ones to calculate the saturation mixing ratio from the tables but the current implementation assumes that the CMEPS flux calculation will be only used by CESM and its driver. Since we are coupling MPAS and MOM6 outside of the CESM framework (at this point) through ESMX driver, the [`shr_wv_sat_qsat_liquid()`](https://github.com/ESCOMP/CMEPS/blob/a0343bcb7c6016960facd6d7bb124223013446bd/cesm/flux_atmocn/flux_atmocn_Large.F90#L219) call returns all zero and flux calculation is messed up. As I see those codes are under driver and it makes sense but I think moving those outside of the driver code and init through the `med.F90` rather then `esm.F90` would make it more generic and it could be also used by UFS WM (I did not check their driver has this init call or not yet) and other projects like ours.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。