AdmiralGT / AdmiralGT/botc-scripts

Feature: mephit and character ID changes should be supported

Aperta
#174 0 commenti 0 reazioni 1 assegnatario Rivendicata da @AdmiralGT Vedi su GitHub
enhancement
Lingua principale
Python
Stelle
33
Fork
27
Merge medio
9m
PR unite (30g)
7

Descrizione

In an attempt to parse information to display on the script page, the ID is looked up in the Character "database" https://github.com/AdmiralGT/botc-scripts/blob/main/scripts/characters.py

Sadly, mephit is not included in this list and so is ignored. However, this means that it is ignored from the statistics page, is displayed poorly on script pages.

I suspect the fix here is to move these characters to the database and then additional information can easily be stored about them e.g. that mephit is the same as mezepheles. Although this could likely also be covered by updating the hard coded information currently available.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.