AdmiralGT / AdmiralGT/botc-scripts

Feature: mephit and character ID changes should be supported

Abierto
#174 0 comentarios 0 reacciones 1 asignado Reclamado por @AdmiralGT Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
33
Forks
27
Merge medio
9 min
PR fusionados (30 d)
7

Descripción

In an attempt to parse information to display on the script page, the ID is looked up in the Character "database" https://github.com/AdmiralGT/botc-scripts/blob/main/scripts/characters.py

Sadly, mephit is not included in this list and so is ignored. However, this means that it is ignored from the statistics page, is displayed poorly on script pages.

I suspect the fix here is to move these characters to the database and then additional information can easily be stored about them e.g. that mephit is the same as mezepheles. Although this could likely also be covered by updating the hard coded information currently available.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.