AdmiralGT / AdmiralGT/botc-scripts

Feature: mephit and character ID changes should be supported

Offen
#174 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @AdmiralGT Auf GitHub ansehen
enhancement
Vorherrschende Sprache
Python
Sterne
33
Forks
27
Ø Merge
9 Min.
Gemergte PRs (30 T.)
7

Beschreibung

In an attempt to parse information to display on the script page, the ID is looked up in the Character "database" https://github.com/AdmiralGT/botc-scripts/blob/main/scripts/characters.py

Sadly, mephit is not included in this list and so is ignored. However, this means that it is ignored from the statistics page, is displayed poorly on script pages.

I suspect the fix here is to move these characters to the database and then additional information can easily be stored about them e.g. that mephit is the same as mezepheles. Although this could likely also be covered by updating the hard coded information currently available.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.