AdmiralGT / AdmiralGT/botc-scripts

Feature: mephit and character ID changes should be supported

Open
#174 0 comments 0 reactions 1 assignee Claimed by @AdmiralGT View on GitHub
enhancement
Dominant language
Python
Stars
33
Forks
27
Avg merge
9m
Merged PRs (30d)
7

Description

In an attempt to parse information to display on the script page, the ID is looked up in the Character "database" https://github.com/AdmiralGT/botc-scripts/blob/main/scripts/characters.py

Sadly, mephit is not included in this list and so is ignored. However, this means that it is ignored from the statistics page, is displayed poorly on script pages.

I suspect the fix here is to move these characters to the database and then additional information can easily be stored about them e.g. that mephit is the same as mezepheles. Although this could likely also be covered by updating the hard coded information currently available.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.