AdmiralGT / AdmiralGT/botc-scripts

Feature: mephit and character ID changes should be supported

Ouverte
#174 0 commentaires 0 réactions 1 personne assignée Réclamée par @AdmiralGT Voir sur GitHub
enhancement
Langage dominant
Python
Étoiles
33
Forks
27
Merge moyen
9 min
PR mergées (30 j)
7

Description

In an attempt to parse information to display on the script page, the ID is looked up in the Character "database" https://github.com/AdmiralGT/botc-scripts/blob/main/scripts/characters.py

Sadly, mephit is not included in this list and so is ignored. However, this means that it is ignored from the statistics page, is displayed poorly on script pages.

I suspect the fix here is to move these characters to the database and then additional information can easily be stored about them e.g. that mephit is the same as mezepheles. Although this could likely also be covered by updating the hard coded information currently available.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.