0xMiden / 0xMiden/protocol

Batch kernel refactoring: align MASM and Rust advice ordering

未关闭
#3,700 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
kernels
主要语言
Rust
星标
132
派生
167
平均合并
1 天 23 小时
30 天内合并 PR
110

描述

Rather than this, I would follow the tx kernel pattern where we setup the advice stack in `TransactionAdviceInputs` in the order in which the tx kernel will read it. This approach would also avoid the explicit `push_mapvaln`s in prepare_batch.

The `push_mapvaln` approach is more explicit, which I also like, but I think the upsides outweigh the downsides.

Separately, I think we should introduce `BatchAdviceInputs` so the advice logic has a better home.

_Originally posted by @PhilippGackstatter in https://github.com/0xMiden/protocol/pull/2905#discussion_r3812858989_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。