0xMiden / 0xMiden/protocol

Batch kernel refactoring: align MASM and Rust advice ordering

Open
#3,700 0 comments 0 reactions 0 assignees View on GitHub
kernels
Dominant language
Rust
Stars
132
Forks
167
Avg merge
1d 23h
Merged PRs (30d)
110

Description

Rather than this, I would follow the tx kernel pattern where we setup the advice stack in `TransactionAdviceInputs` in the order in which the tx kernel will read it. This approach would also avoid the explicit `push_mapvaln`s in prepare_batch.

The `push_mapvaln` approach is more explicit, which I also like, but I think the upsides outweigh the downsides.

Separately, I think we should introduce `BatchAdviceInputs` so the advice logic has a better home.

_Originally posted by @PhilippGackstatter in https://github.com/0xMiden/protocol/pull/2905#discussion_r3812858989_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.