Batch kernel refactoring: align MASM and Rust advice ordering
オープン
kernels
- 主要言語
- Rust
- スター
- 132
- フォーク
- 167
- 平均マージ
- 1日 23時間
- マージ済み PR(30日)
- 110
説明
Rather than this, I would follow the tx kernel pattern where we setup the advice stack in `TransactionAdviceInputs` in the order in which the tx kernel will read it. This approach would also avoid the explicit `push_mapvaln`s in prepare_batch.
The `push_mapvaln` approach is more explicit, which I also like, but I think the upsides outweigh the downsides.
Separately, I think we should introduce `BatchAdviceInputs` so the advice logic has a better home.
_Originally posted by @PhilippGackstatter in https://github.com/0xMiden/protocol/pull/2905#discussion_r3812858989_
コントリビューションガイド
評価
この issue はまだ評価されていません。