0xMiden / 0xMiden/protocol

Batch kernel refactoring: align MASM and Rust advice ordering

Abierto
#3,700 0 comentarios 0 reacciones 0 asignados Ver en GitHub
kernels
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

Rather than this, I would follow the tx kernel pattern where we setup the advice stack in `TransactionAdviceInputs` in the order in which the tx kernel will read it. This approach would also avoid the explicit `push_mapvaln`s in prepare_batch.

The `push_mapvaln` approach is more explicit, which I also like, but I think the upsides outweigh the downsides.

Separately, I think we should introduce `BatchAdviceInputs` so the advice logic has a better home.

_Originally posted by @PhilippGackstatter in https://github.com/0xMiden/protocol/pull/2905#discussion_r3812858989_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.