Batch kernel refactoring: align MASM and Rust advice ordering
Đang mở
kernels
- Ngôn ngữ chính
- Rust
- Star
- 132
- Fork
- 167
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 110
Mô tả
Rather than this, I would follow the tx kernel pattern where we setup the advice stack in `TransactionAdviceInputs` in the order in which the tx kernel will read it. This approach would also avoid the explicit `push_mapvaln`s in prepare_batch.
The `push_mapvaln` approach is more explicit, which I also like, but I think the upsides outweigh the downsides.
Separately, I think we should introduce `BatchAdviceInputs` so the advice logic has a better home.
_Originally posted by @PhilippGackstatter in https://github.com/0xMiden/protocol/pull/2905#discussion_r3812858989_
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.