0xMiden / 0xMiden/protocol

Batch kernel refactoring: align MASM and Rust advice ordering

Offen
#3,700 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
kernels
Vorherrschende Sprache
Rust
Sterne
132
Forks
167
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
110

Beschreibung

Rather than this, I would follow the tx kernel pattern where we setup the advice stack in `TransactionAdviceInputs` in the order in which the tx kernel will read it. This approach would also avoid the explicit `push_mapvaln`s in prepare_batch.

The `push_mapvaln` approach is more explicit, which I also like, but I think the upsides outweigh the downsides.

Separately, I think we should introduce `BatchAdviceInputs` so the advice logic has a better home.

_Originally posted by @PhilippGackstatter in https://github.com/0xMiden/protocol/pull/2905#discussion_r3812858989_

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.