Entity Hub: Refactor get children to work with added entity types support
@iLLiCiTiT đang làm issue này rồi.
Từ ngày 28/10/2024.
- Ngôn ngữ chính
- Python
- Star
- 16
- Fork
- 15
- Merge trung bình
- 1 ngày 9 giờ
- Pull request đã merge (30 ngày)
- 10
Mô tả
Is there an existing issue for this?
- I have searched the existing issues.
Please describe the feature you have in mind and explain what the current shortcomings are?
Current implementation of childrens logic in EntityHub works only for folders and tasks, that does not include products and versions.
How would you imagine the implementation of the feature?
First of all it should be possible to get children of products.
Second issue is that it should be possible to get products as children of folders, but becuase the current logic counts only with folders it is not that easy. When currently available methods are called we should also fetch products with other folders and tasks. But we should add more targetted methods to get only folders, or only products or only tasks, and fetch them and cache their entities respectivelly, so when folder already has known folder entities, but get_children is called we should also look for tasks and products.
Another question is if tasks should option to have version entities as children, because the connection is there we might add it.
Are there any labels you wish to add?
- I have added the relevant labels to the enhancement request.
Describe alternatives you've considered:
No response
Additional context:
No response
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Đánh giá
Issue này chưa được đánh giá.