Entity Hub: Refactor get children to work with added entity types support
@iLLiCiTiT がすでに取り組んでいます。
2024年10月28日 から。
- 主要言語
- Python
- スター
- 16
- フォーク
- 15
- 平均マージ
- 1日 9時間
- マージ済み PR(30日)
- 10
説明
Is there an existing issue for this?
- I have searched the existing issues.
Please describe the feature you have in mind and explain what the current shortcomings are?
Current implementation of childrens logic in EntityHub works only for folders and tasks, that does not include products and versions.
How would you imagine the implementation of the feature?
First of all it should be possible to get children of products.
Second issue is that it should be possible to get products as children of folders, but becuase the current logic counts only with folders it is not that easy. When currently available methods are called we should also fetch products with other folders and tasks. But we should add more targetted methods to get only folders, or only products or only tasks, and fetch them and cache their entities respectivelly, so when folder already has known folder entities, but get_children is called we should also look for tasks and products.
Another question is if tasks should option to have version entities as children, because the connection is there we might add it.
Are there any labels you wish to add?
- I have added the relevant labels to the enhancement request.
Describe alternatives you've considered:
No response
Additional context:
No response
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
評価
この issue はまだ評価されていません。