ynput / ynput/ayon-python-api

Entity Hub: Refactor get children to work with added entity types support

Aperta
#198 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@iLLiCiTiT ci sta già lavorando.

Dal 28/10/2024.

Lingua principale
Python
Stelle
16
Fork
15
Merge medio
1g 9h
PR unite (30g)
10

Descrizione

Is there an existing issue for this?
  • I have searched the existing issues.
Please describe the feature you have in mind and explain what the current shortcomings are?

Current implementation of childrens logic in EntityHub works only for folders and tasks, that does not include products and versions.

How would you imagine the implementation of the feature?

First of all it should be possible to get children of products.

Second issue is that it should be possible to get products as children of folders, but becuase the current logic counts only with folders it is not that easy. When currently available methods are called we should also fetch products with other folders and tasks. But we should add more targetted methods to get only folders, or only products or only tasks, and fetch them and cache their entities respectivelly, so when folder already has known folder entities, but get_children is called we should also look for tasks and products.

Another question is if tasks should option to have version entities as children, because the connection is there we might add it.

Are there any labels you wish to add?
  • I have added the relevant labels to the enhancement request.
Describe alternatives you've considered:

No response

Additional context:

No response

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.